RFR: JDK-8266245: AWT Test FullScreenInsets.java fails due to incorrect pixel color and wrong window bounds [v2]
Andrey Turbanov
aturbanov at openjdk.org
Mon Jan 9 10:01:55 UTC 2023
On Mon, 5 Dec 2022 22:10:15 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:
>> The above test was failing due to incorrect pixel color and wrong window bounds on Mac-ARM, Windows and Linux platforms.
>>
>> The following changes have been made:
>> - Correct window bounds are obtained using the current ScreenDevice's DefaultConfig bounds (this test checks FullScreen functionality on multiple screen devices).
>> - Color tolerance has been added for color check
>> - Instead of scanning the full screen to check pixel color, vertical and horizontal scans are done at the far right and bottom end to ensure that window is in full screen mode w.r.t to screen device and the window bounds are as expected.
>>
>> CI testing passes on all platforms (tested 50 times per platform).
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>
> frame changed back to decorated and exclude on linux
test/jdk/java/awt/FullScreen/FullScreenInsets/FullScreenInsets.java line 190:
> 188: try {
> 189: robot = new Robot();
> 190: } catch(AWTException ae) {
Suggestion:
} catch (AWTException ae) {
-------------
PR: https://git.openjdk.org/jdk/pull/11462
More information about the client-libs-dev
mailing list