RFR: 7131166: SynthListUI / SynthInternalFrameTitlePane updateStyle() ignores method argument

SWinxy duke at openjdk.org
Mon Jan 9 15:31:51 UTC 2023


On Fri, 6 Jan 2023 04:42:37 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> It seems Synth has two cases of updateStyle() where its argument is not passed to the getContext() call. It seems to be an oversight as in other Synth classes, the component argument passed to updateStyle is being passed to getContext().
> 
> CI tests are ok with this change and there is no new regeression with CI tests run in NimbusL&F by default..

This patch is fine, and I think it should be done for consistency. It's weird that `SynthInternalFrameTitlePane` passes itself, but that's not itself a problem; merely an unusual quirk.

-------------

Marked as reviewed by SWinxy at github.com (no known OpenJDK username).

PR: https://git.openjdk.org/jdk/pull/11875



More information about the client-libs-dev mailing list