RFR: 8299522: JFilechooser open button size is incorrectly shown [v2]

[Tejesh R]

On Mon, 9 Jan 2023 17:47:41 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updated based on review comments
>
> test/jdk/javax/swing/JFileChooser/CustomApproveButtonTest.java line 93:
> 
>> 91:         }
>> 92: 
>> 93:         if(frame != null) {
> 
> Spacing

Updated.

> test/jdk/javax/swing/JFileChooser/CustomApproveButtonTest.java line 115:
> 
>> 113:                 if (result == null) {
>> 114:                     result = button;
>> 115:                 }
> 
> What's the `result == null` for? 
> 
> Is it meant to not recursively call findCustomApproveButton() if a JButton result is found? Because then the break at line 107 resolves that I think.
> 
> If it's to only have a result for the first instance of a non-null result, then wouldn't adding a similar break after `result = button` be better so we don't have to recursively call findCustomApproveButton() if a result is already found?

Updated.

-------------

PR: https://git.openjdk.org/jdk/pull/11901