RFR: 8299522: JFilechooser open button size is incorrectly shown [v2]

[Alexey Ivanov]

On Tue, 10 Jan 2023 17:30:27 GMT, Tejesh R <tr at openjdk.org> wrote:

> Yeah, initially had thought of doing this, but to keep the default text open for future changes and to maintain the default for CUSTOM Type separately I added additional properties and members. If using the OPEN type properties is fine for CUSTOM also then can use the same I guess.

It seems fine to me. It's the behaviour if you use the `showDialog` method which shows the same dialog as `showOpenDialog`.

However, Aqua L&F does use special properties, which are used only in the case where the file chooser is embedded in UI hierarchy as opposed to using the `show*Dialog` methods to display a modal dialog box.

> > If you prefer going this route and add new properties, I suggest following what's used in Aqua L&F that is `choose-` prefix for the properties and member names
> 
> Yeah, sure can change the prefix. Along with the approve button text?

Since the type is `CUSTOM_DIALOG`, using `custom-` prefix that you use is actually better as it makes the naming consistent.

However, I'm still inclined to closing this bug as *Not an Issue* because you, as the developer, have to explicitly set the text for the Approve button if you use the customer dialog — it's _custom_ after all.

-------------

PR: https://git.openjdk.org/jdk/pull/11901