RFR: 8299522: JFilechooser open button size is incorrectly shown [v2]

Alexey Ivanov aivanov at openjdk.org
Tue Jan 10 18:06:54 UTC 2023


On Tue, 10 Jan 2023 17:54:35 GMT, Tejesh R <tr at openjdk.org> wrote:

> > However, I'm still inclined to closing this bug as _Not an Issue_ because you, as the developer, have to explicitly set the text for the Approve button if you use the customer dialog — it's _custom_ after all.

Here I meant doing nothing at all. To fix the issue, call `JFileChooser.setApproveButtonText` to set the text for the Approve button.

> Then instead of adding new properties and members let me do as you suggested, to use OPEN type so that the size issue will be handled, and no new properties/members will be introduced. Fine right?

This kind of change shouldn't require a CSR.

[`FileChooserUI.getApproveButtonText`](https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/javax/swing/plaf/FileChooserUI.html#getApproveButtonText(javax.swing.JFileChooser)) does not specify any details. If you apply the diff I suggested, the implementation will remain conformant.

-------------

PR: https://git.openjdk.org/jdk/pull/11901



More information about the client-libs-dev mailing list