RFR: 8299522: Incorrect size of Approve button in custom JFileChooser [v4]

[Andrey Turbanov]

On Wed, 11 Jan 2023 06:35:49 GMT, Tejesh R <tr at openjdk.org> wrote:

>> FileChooser Open/Approve button size is shown incorrectly when no Approve button text is set in `CUSTOM_DIALOG` type. Reason being that no default Approve Button text is returned during Dialog Type Property change. Since `null` is returned as Button string the Button size is incorrectly shown. The fix here addresses the issue by adding a default Approve Button Text when no text is set explicitly in case of `CUSTOM_DIALOG` type.
>> Automated test is attached which has been tested with multiple test runs.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Reverting aqua check condition

src/java.desktop/share/classes/javax/swing/plaf/basic/BasicFileChooserUI.java line 586:

> 584:         }
> 585: 
> 586:         if(fc.getDialogType() == JFileChooser.OPEN_DIALOG ||

Suggestion:

        if (fc.getDialogType() == JFileChooser.OPEN_DIALOG ||

-------------

PR: https://git.openjdk.org/jdk/pull/11901