RFR: 8299522: Incorrect size of Approve button in custom JFileChooser [v6]
Alexey Ivanov
aivanov at openjdk.org
Fri Jan 13 12:03:18 UTC 2023
On Fri, 13 Jan 2023 06:44:05 GMT, Tejesh R <tr at openjdk.org> wrote:
>> test/jdk/javax/swing/JFileChooser/CustomApproveButtonTest.java line 83:
>>
>>> 81: }
>>> 82: if (customApproveButton.getText() == null) {
>>> 83: fail("Custom Approve Button Text is null in FileChooser!");
>>
>> Suggestion:
>>
>> fail("Approve button text is null in FileChooser!");
>
> Updated.
I wonder why do you like title-style capitalisation in exception messages.
“Approve Button Text” is appropriate if it's a title of something. Since it's a message, “Approve button text” should be used instead.
-------------
PR: https://git.openjdk.org/jdk/pull/11901
More information about the client-libs-dev
mailing list