RFR: 8300084: AquaFileChooserUI.getDefaultButton returns null
Alexey Ivanov
aivanov at openjdk.org
Mon Jan 16 12:21:10 UTC 2023
On Mon, 16 Jan 2023 11:33:39 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> In Aqua look and feel, `getDefaultButton()` of `JFileChooser` returns null. The fix overrides the method from `FileChooserUI` to return the `ApproveButton` of `FileChooser` which is similar to other L&F.
>> The test is run for multiple iterations in CI machine.
>
> test/jdk/javax/swing/JFileChooser/AquaDefaultButtonTest.java line 48:
>
>> 46: if (defaultApproveButton == null) {
>> 47: throw new RuntimeException("getDefaultButton() method returns null for Aqua L&F!");
>> 48: }
>
> If you choose shorter names for variables, the line would fit into 80-column limit. Now the two lines are nearly 100 characters long, though not a big issue.
Could you please the copyright year in `AquaFileChooserUI.java`?
-------------
PR: https://git.openjdk.org/jdk/pull/12008
More information about the client-libs-dev
mailing list