RFR: 8300084: AquaFileChooserUI.getDefaultButton returns null [v2]

Alexey Ivanov aivanov at openjdk.org
Mon Jan 16 13:49:27 UTC 2023


On Mon, 16 Jan 2023 13:38:32 GMT, Tejesh R <tr at openjdk.org> wrote:

> > It's exactly the point: **include Aqua L&F in #11901**. The Aqua L&F is excluded only because `getDefaultButton` returns null, isn't it? This fix makes it return non-null, therefore Aqua L&F can be included in testing.
> >
> > This fix should be integrated before [JDK-8299522](https://bugs.openjdk.org/browse/JDK-8299522). I will not approve #11901 until Aqua L&F is part of the `CustomApproveButtonTest.java` test.
>
> The Aqua L&F is excluded not only because `getDefaultButton` returns null, but it is also excluded because the fix doesn't apply to Aqua L&F. Still if u insist to use the same test then can do that, as u said first this fix will go in and then #11901.

I do insist.

The fix does not apply to Aqua L&F only because this situation has already be taken care of in Aqua L&F. Now all L&Fs are expected to return non-null text for the Approve button, I see no reason why Aqua L&F is skipped in testing: it is still expected that the Approve button in Aqua L&F is not null.

-------------

PR: https://git.openjdk.org/jdk/pull/12008



More information about the client-libs-dev mailing list