RFR: 8299522: Incorrect size of Approve button in custom JFileChooser [v10]

Alexey Ivanov aivanov at openjdk.org
Tue Jan 17 17:29:23 UTC 2023


On Tue, 17 Jan 2023 05:00:47 GMT, Tejesh R <tr at openjdk.org> wrote:

>> test/jdk/javax/swing/JFileChooser/CustomApproveButtonTest.java line 71:
>> 
>>> 69:             frame.setVisible(true);
>>> 70: 
>>> 71:             JButton customApproveButton = fileChooser.getUI().getDefaultButton(fileChooser);
>> 
>> we should check the changes in getApproveButtonToolTipText and getApproveButtonMnemonic as well.
>
> For Mnemonic the default value is zero, so just have to check if its zero right......?

The default value depends on L&F, yet it looks like no L&Fs that are part of JDK set a mnemonic, which makes perfect sense for the default button in a dialog box.

This may call for an additional test which ensures the custom dialog has mnemonic of the Open button.

-------------

PR: https://git.openjdk.org/jdk/pull/11901



More information about the client-libs-dev mailing list