RFR: 8300117: Replace use of JNI_COMMIT mode with mode 0

Phil Race prr at openjdk.org
Tue Jan 17 18:22:51 UTC 2023


On Tue, 17 Jan 2023 07:43:41 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

> Please review this patch that fixes memory leaks in native code.
> 
> The call to `ReleaseXXArrayElements` with `JNI_COMMIT` parameter does not release the native buffer allocated by the previous `GetXXArrayElements` call. The buffer pointers were only stored in local variables and were lost on function exit.
> 
> No new regression test; existing tests under `java/awt/dnd` and `java/awt/datatransfer` cover all 3 modified functions.
> 
> Mach5 clientlibs tests continue to pass.

I agree these all look like they should request the array to be freed.

-------------

Marked as reviewed by prr (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12023



More information about the client-libs-dev mailing list