RFR: 8300269: The selected item in an editable JComboBox with titled border is not visible in Aqua LAF [v3]

Damon Nguyen dnguyen at openjdk.org
Fri Jan 20 22:45:32 UTC 2023


> The fixed height causes the titled border insets to reserve a majority of the height available for the component. This fixed height is meant for the default AquaComboBox usage, so the old default height is more applicable when a border, such as TitledBorder, is set on an Aqua Editable ComboBox.
> 
> A conditional to check for a border is added since this is the default for an AquaComboBox using AquaBorder in AquaComboBoxUI's rectangleForCurrentValue() step. A check for any border rather than an instance of a TitledBorder is used because this issue causes changes in other borders as well (I found it for LineBorder for example). 
> 
> The editable JComboBox is visible with a LineBorder, but the coordinates of the comboBox are aligned with the top of the arrowButton instead of the bottom (which was the case before the previous fix). So, the method now defaults to the behavior before the fix for any editable comboBox pre-fix if a different border is set.

Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:

  Change bounds to toolkit screen size

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/12087/files
  - new: https://git.openjdk.org/jdk/pull/12087/files/c093ef7a..5f6fc71f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=12087&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12087&range=01-02

  Stats: 6 lines in 1 file changed: 3 ins; 1 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/12087.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12087/head:pull/12087

PR: https://git.openjdk.org/jdk/pull/12087



More information about the client-libs-dev mailing list