RFR: 7131166: SynthListUI / SynthInternalFrameTitlePane updateStyle() ignores method argument
Prasanta Sadhukhan
psadhukhan at openjdk.org
Mon Jan 23 06:14:04 UTC 2023
On Mon, 23 Jan 2023 06:01:42 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
> It seems true that the code expects to always read the styles from the protected field, and that intention seems to be the opposite of what we do in the current change, no?
Also, it is done same for all other SYnth classes as I told earlier too.
For example, in SynthTable, it calls `updateStyle((JTable)event.getSource());` whereas in updateStyle() we use
`SynthContext context = getContext(c, ENABLED);` even though we have protected field `protected JTable table;` in BasicTableUI being used in updateStyle() in SynthTableUI
so I think it was mistakenly done and it is remedied in current fix, otherwise we need to do SynthListUI changes to use protected field in other Synth classes too, but since the other way around is in majority, I think this is what should be done for consistency..
-------------
PR: https://git.openjdk.org/jdk/pull/11875
More information about the client-libs-dev
mailing list