RFR: JDK-8292276 : Add named colors from CSS Color Module Level 4 [v23]

Alexey Ivanov aivanov at openjdk.org
Wed Jan 25 22:16:29 UTC 2023


On Sat, 21 Jan 2023 18:15:43 GMT, ScientificWare <duke at openjdk.org> wrote:

>> ScientificWare has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>    Moves jtreg tags to the class declaration
>>   
>>   Comment with tags isn't collapsed when viewed in an IDE if it's placed before the class declaration.
>
> Still waiting a review.

@scientificware could you put your suggested text into the code change? I mean incorporate into the PR itself.

Is it necessary to have the _long_ sample code?

> @aivanov-jdk Can we dissociate the release of the code from the stringToColor specification update ? I'm not ready with [rgb implementation](https://bugs.openjdk.org/browse/JDK-8294090) as described in this specifications.

If the other part isn't ready yet, let's skip it for now. Once ready, you'll update the javadoc accordingly.

-------------

PR: https://git.openjdk.org/jdk/pull/9825



More information about the client-libs-dev mailing list