RFR: 8298385: Some font classes rely on blind casting to implement Object.equals()

SWinxy duke at openjdk.org
Thu Jan 26 02:16:37 UTC 2023


On Fri, 9 Dec 2022 00:35:48 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Some also had two separate methods to check equality, one calling the other. Objects.equals() is used in some places as a replacement for a local copy of the function. In the end, the equals methods become quicker to understand their checks, more condensed, and becomes more in line with other equality methods in the JDK.
>
> src/java.desktop/share/classes/java/awt/font/FontRenderContext.java line 316:
> 
>> 314:      * @since 1.4
>> 315:      */
>> 316:     public boolean equals(FontRenderContext rhs) {
> 
> The public methods in the public classes in the `java/awt/*` package are part of the public API, it is not possible to delete such methods.

Whoops. Thanks for catching that.

-------------

PR: https://git.openjdk.org/jdk/pull/10416



More information about the client-libs-dev mailing list