RFR: 8300929: Avoid unnecessary array fill after creation in java.awt.image [v2]
Andrey Turbanov
aturbanov at openjdk.org
Thu Jan 26 09:28:50 UTC 2023
On Tue, 24 Jan 2023 22:50:31 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:
>> Yeah, please, no commented-out code. I'd be fine with the code as it was, I don't think it needs much clarification. If @mrserb insists on a comment then I agree that a comment on the array declaration should be sufficient.
>
> That is not about the default values in the array but about missing initialization of `bandOffsets`, which we will skip intentionally. So it won't raise the question later why we initiated the Indices and not offsets.
I've added comment and moved array declaration. I think currently code is clear enough.
-------------
PR: https://git.openjdk.org/jdk/pull/12147
More information about the client-libs-dev
mailing list