RFR: 8081474: SwingWorker calls 'done' before the 'doInBackground' is finished [v3]
Prasanta Sadhukhan
psadhukhan at openjdk.org
Fri Jan 27 05:08:16 UTC 2023
On Fri, 13 Jan 2023 04:03:55 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
>> SwingWorker done() method [spec ](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/SwingWorker.java#L452) says "Executed on the Event Dispatch Thread after the doInBackground method is finished"
>> but there's no mechanism in place to honor that claim.
>> The [spec](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/SwingWorker.java#L289)
>> also says the state should be DONE after doInBackground() returns which is also not done.
>>
>> Modified the code to honour the specification.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>
> Remove blocking thread sleep for EDT
Any more comments on this?
Should we close the JBS as "Not an issue"?
or
Should we just update the spec citing it's not necessary to wait for doInBackground() to finish before done() is called?
or
any other suggestion for the fix?
-------------
PR: https://git.openjdk.org/jdk/pull/11940
More information about the client-libs-dev
mailing list