RFR: 6187113: DefaultListSelectionModel.removeIndexInterval(0, Integer.MAX_VALUE) fails [v12]

Prasanta Sadhukhan psadhukhan at openjdk.org
Mon Jan 30 07:40:22 UTC 2023


> DefaultListSelectionModel.removeIndexInterva accepts `int` value which allows it to take in Integer.MAX_VALUE theoratically but it does calculation with that value which can results in IOOBE.
> Fix is to make sure the calculation stays within bounds.

Prasanta Sadhukhan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 15 additional commits since the last revision:

 - Merge branch 'master' of https://git.openjdk.java.net/jdk into JDK-6187113
 - Update copyright year
 - Review fix
 - Review fix
 - Review fix
 - Review comment fix
 - removeIndexInterval, insertIndexInterval fix
 - insertIndexInterval fix. Add more subtests
 - javadoc update
 - Review comment to exclude MAX_VALUE
 - ... and 5 more: https://git.openjdk.org/jdk/compare/17e00224...eb99ea3b

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/10409/files
  - new: https://git.openjdk.org/jdk/pull/10409/files/da05d20e..eb99ea3b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=10409&range=11
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10409&range=10-11

  Stats: 487548 lines in 7616 files changed: 244698 ins; 156619 del; 86231 mod
  Patch: https://git.openjdk.org/jdk/pull/10409.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10409/head:pull/10409

PR: https://git.openjdk.org/jdk/pull/10409



More information about the client-libs-dev mailing list