RFR: 8301342: Prefer ArrayList to LinkedList in LayoutComparator

Phil Race prr at openjdk.org
Mon Jan 30 22:56:55 UTC 2023


On Sat, 28 Jan 2023 14:54:38 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

> There is only add/iterator calls on this list. No removes from the head or something like this. Not sure why LinkedList was used, but ArrayList should be preferred as more efficient and widely used (more chances for JIT) collection

I expect some testing to be done before it is pushed.

This looks safe but  I rather doubt anyone will be able to measure or ever see any performance benefit.
I suggest some manual testing of focus traversal which seems to be the sole user of the containing class.

-------------

Marked as reviewed by prr (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12274



More information about the client-libs-dev mailing list