RFR: 6817009: Action.SELECTED_KEY not toggled when using key binding
Andrey Turbanov
aturbanov at openjdk.org
Tue Jan 31 06:55:57 UTC 2023
On Fri, 27 Jan 2023 10:26:10 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
> When the Action.SELECTED_KEY property action is assigned to ToggleButton and an accelerator key binding is mapped to the action, then pressing the accelerator key binding does not toggle the toggle button.
> This is because SwingUtilities.notifyAction does not fire itemStateChanged event for such action related to SELECTED_KEY.
> Fix is to get the Action.SELECTED_KEY command/action and fire itemStateChanged Event via JToggleButton.setSelected() call to notify propertyChange listener of the toggled property.
test/jdk/javax/swing/JToggleButton/TestSelectedKey.java line 96:
> 94: action.addPropertyChangeListener(new PropertyChangeListener() {
> 95: public void propertyChange(PropertyChangeEvent evt) {
> 96: if(Action.SELECTED_KEY.equals(evt.getPropertyName())) {
Suggestion:
if (Action.SELECTED_KEY.equals(evt.getPropertyName())) {
-------------
PR: https://git.openjdk.org/jdk/pull/12253
More information about the client-libs-dev
mailing list