RFR: 6875229: Wrong placement of icons in JTabbedPane in Nimbus

Jayathirth D V jdv at openjdk.org
Tue Jul 4 11:39:58 UTC 2023


On Wed, 28 Jun 2023 18:38:16 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Icon is placed after text in JTabbedPane for NimbusL&F since the text is drawn at LEADING position instead of TRAILING as is done for [other L&F](https://github.com/openjdk/jdk/blob/59c6c0e1b7148a7139f5e6a4ba2b19623c20c77d/src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTabbedPaneUI.java#L1155-L1160)
>> 
>> Before fix
>> ![image](https://github.com/openjdk/jdk/assets/43534309/10d3f919-46e0-47e9-9d27-b33e49b2d62c)
>> 
>> After fix
>> ![image](https://github.com/openjdk/jdk/assets/43534309/0c4906ec-df2a-4ce6-8399-fd1cd9e34450)
>
> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthTabbedPaneUI.java line 659:
> 
>> 657:                     tabIndex, clippedTitle, textRect, isSelected);
>> 658: 
>> 659: 
> 
> What's the purpose of moving this line? Doesn't seem to change anything from what I've tested so far.

@prsadhuk Is there any change in rendering based on what we draw first?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14596#discussion_r1251903244



More information about the client-libs-dev mailing list