RFR: 8311031: JTable header border vertical lines are not aligned with data grid lines

[Tejesh R]

On Wed, 5 Jul 2023 12:46:26 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>>> > > That gap is caused because of alignment miss-match between vertical lines of header border and data grid lines. To be specific the header vertical line is slightly left (around a pixel) than data grid line.
>>> > 
>>> > 
>>> > Is it require to address?
>>> 
>>> I'd rather say ‘yes’. Since you're trying to improve border rendering, it's better to fix this inconsistency too.
>>> 
>>> But to get pixel-perfect rendering, you may need to remove the scale transform.
>> 
>> I'm not sure if it is a bug, the gap is because of white lines drawn for each header cell (bottom-left till top-left and then to to-right for each header cell). Kind of shade effect.
>
>> I'm not sure if it is a bug, the gap is because of white lines drawn for each header cell (bottom-left till top-left and then to to-right for each header cell). Kind of shade effect.
> 
> I admit I am confused to which part it refers.
> 
> I re-checked your after screenshot and it looks fine to me. The shadow is followed by white highlight. There was background colour seen between these two colours in the before-fix screenshot.
> 
> There's still a 2-pixel background colour under the highlight. Yet it is present in the before-fix too, so it looks it is designed this way for a smoother 3D shading effect.

@aivanov-jdk @kumarabhi006 Is there anything else w.r.t fix and automated test ? I think have addressed your review suggestions.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14766#issuecomment-1623036859