RFR: 8140527: JInternalFrame has incorrect title button width [v4]

Prasanta Sadhukhan psadhukhan at openjdk.org
Fri Jul 7 04:01:57 UTC 2023


On Thu, 6 Jul 2023 20:08:37 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> > > Having said that, I guess XP theme also padding is not correct as can be seen in this bug [JDK-8139392](https://bugs.openjdk.org/browse/JDK-8139392) which I have rectified
> > > After fix
> > > ![image](https://user-images.githubusercontent.com/43534309/248217142-224f098c-5ff5-4713-8434-05d99e7d9a71.png)
> > 
> > 
> > Your latest changes also fix [JDK-8139392](https://bugs.openjdk.org/browse/JDK-8139392), do I get it right? If so, add it to the list of fixed issues.
> 
> This change does not address JDK-8139392 fully. The title bar buttons in Vista theme, which are still used for MDI windows, are not square. The dimensions of the native buttons are 32×18. The dimensions of the JInternalFrame title bar buttons after your fix are 24×18; before your fix they were 28×18. That is the width of the buttons is smaller by 8 and 4 pixels. Aren't these the values subtracted from the width value fetched from Windows?
> 

Adjusted to native button dimensions of 32x18

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14555#issuecomment-1624647368



More information about the client-libs-dev mailing list