RFR: 8283214: [macos] Screen magnifier does not show the magnified text for JcomboBox [v5]

Abhishek Kumar abhiscxk at openjdk.org
Tue Jul 11 07:52:14 UTC 2023


On Thu, 6 Jul 2023 11:54:41 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>>> Do you think it is correct?
>>>
>>> I admit refactoring / rewriting accessibility implementation for JComboBox is out of scope in this bug. Yet the current way doesn't feel right.
>> 
>> I think so. 
>> If I am not wrong the non-editable JComboBox doesn't have any editor, so the arrowButton width and height is equal to the combobox width and height. This results in arrowbutton rendering for entire display area of combobox. Due to this we are getting the accessible interface invoked for combobox button.
>
> Yes, non-editable combo box doesn't have the editor. Yet the arrowButton is not what displays the text. It is for this reason that I think it is wrong that the button becomes the main component which handles accessibility for combo box if it's not editable. It is not the button that displays the text.
> 
> Setting accessible name in `doRendererPaint` doesn't feel right either.

As per our discussion, I didn't find other way to set the accessible name.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14497#discussion_r1259330533



More information about the client-libs-dev mailing list