RFR: JDK-8302618: [macOS] Problem typing uppercase letters with java.awt.Robot when moving mouse [v5]

Harshitha Onkar honkar at openjdk.org
Wed Jul 12 17:48:20 UTC 2023


On Mon, 10 Jul 2023 20:24:47 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   minor test changes
>
> test/jdk/java/awt/Robot/RobotModifierMaskTest.java line 261:
> 
>> 259:             boolean condition = expectedResult.equals(EXPECTED_RESULT_CTRL)
>> 260:                                 ? (jTextArea.getCaretPosition()
>> 261:                                      != Integer.parseInt(EXPECTED_RESULT_CTRL))
> 
> You pass different expected result strings but here you always compare `expectedResult` to `EXPECTED_RESULT_CTRL`. Is it intentional? Do I miss anything?
> 
> I haven't run the test.

@aivanov-jdk Will be restructuring test case using Predicate as suggested.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14744#discussion_r1261514490



More information about the client-libs-dev mailing list