RFR: 8311033: [macos] PrinterJob does not take into account Sides attribute [v2]

Alexander Scherbatiy alexsch at openjdk.org
Fri Jul 14 14:35:48 UTC 2023


> To reproduce the issue run the [JavaSidesAttributePrinting](https://bugs.openjdk.org/secure/attachment/104448/JavaSidesAttributePrinting.java) java sample with ONE_SIDED and DUPLEX arguments on macOS:
> 
> java JavaSidesAttributePrinting ONE_SIDED
> java JavaSidesAttributePrinting DUPLEX
> 
> 
> The sample calls PrinterJob print method with the given sides attribute.
> The pages are printed according to the printer default settings not according to the provided Sides attributes.
> 
> The fix propagates Sides attribute
> - from `PrinterJob` to `NSPrintInfo` in `CPrinterJob.javaPrinterJobToNSPrintInfo` method
> - from `NSPrintInfo` to `PrinterJob` in `CPrinterJob.nsPrintInfoToJavaPrinterJob` method

Alexander Scherbatiy has updated the pull request incrementally with one additional commit since the last revision:

  Check supported sides attributes in the test.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/14727/files
  - new: https://git.openjdk.org/jdk/pull/14727/files/7246677c..65c9a23a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=14727&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14727&range=00-01

  Stats: 66 lines in 1 file changed: 49 ins; 0 del; 17 mod
  Patch: https://git.openjdk.org/jdk/pull/14727.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14727/head:pull/14727

PR: https://git.openjdk.org/jdk/pull/14727



More information about the client-libs-dev mailing list