Integrated: 8140527: JInternalFrame has incorrect title button width

Prasanta Sadhukhan psadhukhan at openjdk.org
Mon Jul 17 08:43:28 UTC 2023


On Tue, 20 Jun 2023 10:04:53 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Title buttons under Widows Classic L&F got their sizes from the XP desktop theme in which button width can be bigger than height. It is construed as XP bug where sizes aren't updated properly so it uses height units for width for XP and later windows. The proposed fix uses the [same technique](https://github.com/openjdk/jdk/blob/a0595761ef35c4eec8cb84326a869b9473cd5bba/src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsInternalFrameTitlePane.java#L78-L82) for Classic and forces title buttons to be square and to fit the frame title in height.
> 
> Before fix SwingSet2 demo (Windows Classic InternalFrame)
> ![image](https://github.com/openjdk/jdk/assets/43534309/3d6ec539-5e17-46ce-aba5-e724af6085fe)
> 
> After fix
> ![image](https://github.com/openjdk/jdk/assets/43534309/db0135e4-d7f3-41a4-bbfa-e8e95cbd071d)

This pull request has now been integrated.

Changeset: acf591e8
Author:    Prasanta Sadhukhan <psadhukhan at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/acf591e856ce4b43303b1578bd64a8c9ab0063ea
Stats:     187 lines in 3 files changed: 153 ins; 15 del; 19 mod

8140527: JInternalFrame has incorrect title button width
8139392: JInternalFrame has incorrect padding

Co-authored-by: Alexey Ivanov <aivanov at openjdk.org>
Reviewed-by: aivanov, tr

-------------

PR: https://git.openjdk.org/jdk/pull/14555



More information about the client-libs-dev mailing list