RFR: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library [v2]

Renjith Kannath Pariyangad duke at openjdk.org
Thu Jul 20 03:41:41 UTC 2023


On Wed, 19 Jul 2023 00:07:05 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updated copyright year
>
> src/java.desktop/windows/native/libjsound/PLATFORM_API_WinOS_DirectSound.cpp line 482:
> 
>> 480: DWORD WINAPI __stdcall DS_StartBufferHelper::ThreadProc(void *param)
>> 481: {
>> 482:     ::CoInitializeEx(NULL, COINIT_MULTITHREADED);
> 
> The documentation for the `CoInitializeEx` suggests to disable the `COINIT_DISABLE_OLE1DDE`: 
> https://learn.microsoft.com/en-us/windows/win32/learnwin32/initializing-the-com-library
> 
> I think we do not need ole1 here and can disable that.

@mrserb, thank you for your review I have disabled ole1 by adding the flag `COINIT_DISABLE_OLE1DDE`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14898#discussion_r1268894199



More information about the client-libs-dev mailing list