RFR: 8280482: Window transparency bug on Linux [v2]

Tejesh R tr at openjdk.org
Thu Jul 20 17:35:42 UTC 2023


On Thu, 20 Jul 2023 12:46:39 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review fix
>
> test/jdk/java/awt/Multiscreen/MultiScreenCheckScreenIDTest.java line 128:
> 
>> 126:                 //Check if GC is changed for windows positioned in screen 0.
>> 127: 
>> 128:                 if (windowXPos < screen1Width) {
> 
> This type of check fails for following display arrangement
> ![image](https://github.com/openjdk/jdk/assets/77687766/e2881415-9ecd-4695-bcc0-2dc98ccd382e)
> 
> I suggest to check if window's GraphicsConfiguration is associated with correct screen device
> (e.g. check if the window bounds within the `window.getGraphicsConfiguration().getDevice().getBounds()`).
> 
> It also seems more reliable to me if we don't check the GraphicsConfiguration only within the `graphicsConfiguration` change event, but unconditionally after some delay after the window is displayed (in case the event doesn't occur).

_I suggest to check if window's GraphicsConfiguration is associated with correct screen device
(e.g. check if the window bounds within the window.getGraphicsConfiguration().getDevice().getBounds())._
I didn't get this suggestion. Does it means to compare GC or the position of every `window` with corresponding `window.getGraphicsConfiguration().getBounds()`.......? `window.getGraphicsConfiguration().getBounds()` shows same for all the windows, either in primary/secondary monitor.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14825#discussion_r1269767136



More information about the client-libs-dev mailing list