RFR: 6442919: JFilechooser popup still left-to-right when JFilechooser is set to right-to-left

Sergey Bylokhov serb at openjdk.org
Fri Jul 21 03:35:44 UTC 2023


On Thu, 20 Jul 2023 09:40:41 GMT, Tejesh R <tr at openjdk.org> wrote:

> Popup menu is created on mouse click, hence the orientation for FileChooser won't apply to the popup menu created. Hence the fix address the issue by applying the FileChooser orientation when it is created on mouse operation (Right Click). 
> The test does not apply to Motif and Aqua Look And Feel since right click is not supported on filePane of FileChooser, hence it is skipped. The fix is tested in CI and it is green.

test/jdk/javax/swing/JFileChooser/FCPopupMenuOrientationTest.java line 51:

> 49:                         UIManager.getInstalledLookAndFeels()) {
> 50:                     String className = laf.getName().toLowerCase();
> 51:                     if (className.contains("motif") || className.contains("mac")) {

The test does not have a headful keyword so in the CI it was tested on a headless system where the GTK l&f is unsupported. Please double-check - do we need to skip it here or not?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14949#discussion_r1270192494



More information about the client-libs-dev mailing list