RFR: 8280482: Window transparency bug on Linux [v2]

[Tejesh R]

On Thu, 20 Jul 2023 12:48:54 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review fix
>
> test/jdk/java/awt/Multiscreen/MultiScreenCheckScreenIDTest.java line 46:
> 
>> 44:  * @key headful
>> 45:  * @requires (os.family == "linux")
>> 46:  * @library /java/awt/regtesthelpers
> 
> Is the regtesthepers actually being used?

Removed.

> test/jdk/java/awt/Multiscreen/MultiScreenCheckScreenIDTest.java line 62:
> 
>> 60:             createGUI();
>> 61:         } finally {
>> 62:             for (Window win : windowList) {
> 
> Looks like you don't wait for possible `graphicsConfiguration` change events to come here, and start closing all windows.

Since GC change event is removed now and also added some delay.

> test/jdk/java/awt/Multiscreen/MultiScreenCheckScreenIDTest.java line 98:
> 
>> 96:                     });
>> 97: 
>> 98:                     Thread.sleep(100);
> 
> I think that we can show all the windows at once without this delay to speed up the test execution.

Removed. Also No need to test for full screen I guess, just the top row checking will be fine I guess. Updated the test to check only for top row.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14825#discussion_r1270364344
PR Review Comment: https://git.openjdk.org/jdk/pull/14825#discussion_r1270365563
PR Review Comment: https://git.openjdk.org/jdk/pull/14825#discussion_r1270367132