RFR: 8311033: [macos] PrinterJob does not take into account Sides attribute [v3]
Alexander Scherbatiy
alexsch at openjdk.org
Fri Jul 21 14:55:45 UTC 2023
On Thu, 20 Jul 2023 01:30:06 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:
>> Alexander Scherbatiy has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Local supportedSides variable is used insted of supportedSides field
>
> src/java.desktop/macosx/native/libawt_lwawt/awt/CPrinterJob.m line 531:
>
>> 529: }
>> 530:
>> 531: int sides = (*env)->CallIntMethod(env, srcPrinterJob, jm_getSides);
>
> it seems the code around uses the "java" types like jint.
>>jint copies = (*env)->CallIntMethod(env, srcPrinterJob, jm_getCopies);
Could you review the updated fix?
`int` type is changed to `jint` for sides variable.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14727#discussion_r1270769489
More information about the client-libs-dev
mailing list