RFR: 8311033: [macos] PrinterJob does not take into account Sides attribute [v4]

Fri Jul 21 19:21:43 UTC 2023

On Fri, 21 Jul 2023 14:36:09 GMT, Alexander Scherbatiy <alexsch at openjdk.org> wrote:

>> To reproduce the issue run the [JavaSidesAttributePrinting](https://bugs.openjdk.org/secure/attachment/104448/JavaSidesAttributePrinting.java) java sample with ONE_SIDED and DUPLEX arguments on macOS:
>> 
>> java JavaSidesAttributePrinting ONE_SIDED
>> java JavaSidesAttributePrinting DUPLEX
>> 
>> 
>> The sample calls PrinterJob print method with the given sides attribute.
>> The pages are printed according to the printer default settings not according to the provided Sides attributes.
>> 
>> The fix propagates Sides attribute
>> - from `PrinterJob` to `NSPrintInfo` in `CPrinterJob.javaPrinterJobToNSPrintInfo` method
>> - from `NSPrintInfo` to `PrinterJob` in `CPrinterJob.nsPrintInfoToJavaPrinterJob` method
>
> Alexander Scherbatiy has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Change int type to jint for sides variable in CPrinterJob.m

Marked as reviewed by serb (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/14727#pullrequestreview-1541717663