RFR: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library [v3]

Alexey Ivanov aivanov at openjdk.org
Mon Jul 24 10:45:43 UTC 2023


On Thu, 20 Jul 2023 03:39:03 GMT, Renjith Kannath Pariyangad <duke at openjdk.org> wrote:

>> Hi Reviewers,
>> 
>> Observations :
>> 1. Without com initialize if we access Mixer for recording, library loaded invalid GUID and clipped description in windows(ID not found in registry). With com initialization library load proper GUID (same as registry).
>> 2. For Play back device always loading proper device GUID irrespective of com Initialization.
>> 
>> Test:
>> Since screen lock and unlock workflow required for reproducing this issue, did coupe of iteration of manual testing post fix and confirmed its resolving the problem.
>> To reconfirm nothing is broken, executed all audio related test cases on test bench post fix and all are green.
>> 
>> Please review the changes and let me know your comments if any.
>> 
>> Regards,
>> Renjith.
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Disabled OLE1 from CoInit

The test case attached to [JDK-8301846](https://bugs.openjdk.org/browse/JDK-8301846) breaks after `JFileChooser` is created and the screen is locked and unlocked.

I wonder if `JFileChooser` operations are affected by the suggested fix: can `JFileChooser` still navigate to virtual folders on Windows and display file icons correctly while playing and/or recording audio?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14898#issuecomment-1647665207



More information about the client-libs-dev mailing list