RFR: 8296972: [macos13] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java: getExtendedState() != 6 as expected. [v6]
Dmitry Markov
dmarkov at openjdk.org
Mon Jul 24 16:36:55 UTC 2023
On Mon, 24 Jul 2023 00:38:52 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:
>> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
>>
>> added test cases, fixed spacing
>
> src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java line 989:
>
>> 987: synchronized (lock) {
>> 988: try {
>> 989: lock.wait();
>
> Are we sure that waiting forever is a good thing? Can this request be ignored by the OS for any reason?
It is very unlikely that we are waiting forever here unless there are some serious problems with corresponding platform API.
I understand your concern and agree that waiting for some reasonable time instead of forever is more suitable here.
@alisenchung Can you open a bug to replace forever waiting with timeout.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14226#discussion_r1272499505
More information about the client-libs-dev
mailing list