RFR: JDK-8302618: [macOS] Problem typing uppercase letters with java.awt.Robot when moving mouse [v7]

Harshitha Onkar honkar at openjdk.org
Mon Jul 24 21:59:47 UTC 2023


On Mon, 24 Jul 2023 18:27:20 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   test changes: added CountDownLatch
>
> test/jdk/java/awt/Robot/RobotModifierMaskTest.java line 245:
> 
>> 243:     private static void createTestUI() {
>> 244:         String mode = isManual ? "MANUAL" : "AUTOMATED";
>> 245:         jFrame = new JFrame("RobotModifierMaskTest - Mode: " + mode);
> 
> Should you dispose of the instruction frame in the manual mode?

Since I'm reusing the same `jFrame` variable, disposing of jFrame is handled in the finally block.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14744#discussion_r1272796737



More information about the client-libs-dev mailing list