RFR: 8283214: [macos] Screen magnifier does not show the magnified text for JcomboBox [v6]

[Abhishek Kumar]

On Mon, 24 Jul 2023 19:11:00 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   bugid removed in comments
>
> src/java.desktop/macosx/classes/com/apple/laf/AquaComboBoxButton.java line 34:
> 
>> 32: 
>> 33: import apple.laf.JRSUIState;
>> 34: import apple.laf.JRSUIConstants.*;
> 
> I think we should expand all wild card imports.

Updated.

> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicComboBoxUI.java line 1131:
> 
>> 1129:         switch ( i ) {
>> 1130:             case 0:
>> 1131:                 if ( popup instanceof Accessible accessiblePopup) {
> 
> Suggestion:
> 
>                 if (popup instanceof Accessible accessiblePopup) {

This code segment is reverted back and handled in `AquaComboBoxUI` now.

> test/jdk/javax/accessibility/JComboBox/TestJComboBoxScreenMagnifier.java line 50:
> 
>> 48:             "1) Enable Screen magnifier on the Mac \n\n" +
>> 49:                 "System Preference -> Accessibility -> Zoom -> " +
>> 50:                 "Select ( Enable Hover Text) \n\n" +
> 
> Suggestion:
> 
>                 "Select "Enable Hover Text"\n\n" +

Updated.

> test/jdk/javax/accessibility/JComboBox/TestJComboBoxScreenMagnifier.java line 58:
> 
>> 56:              InvocationTargetException {
>> 57:         PassFailJFrame passFailJFrame = new PassFailJFrame(
>> 58:                 "JMenu Screen Magnifier Test Instructions", INSTRUCTIONS, 5, 12, 40);
> 
> Suggestion:
> 
>                 "JComboBox Screen Magnifier Test Instructions", INSTRUCTIONS, 5, 12, 40);

Updated.

> test/jdk/javax/accessibility/JComboBox/TestJComboBoxScreenMagnifier.java line 63:
> 
>> 61:         passFailJFrame.awaitAndCheck();
>> 62:     }
>> 63:     private static void createAndShowUI() {
> 
> Suggestion:
> 
>     }
> 
>     private static void createAndShowUI() {
> 
> 
> Please add a blank line between methods.

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14497#discussion_r1273426943
PR Review Comment: https://git.openjdk.org/jdk/pull/14497#discussion_r1273426473
PR Review Comment: https://git.openjdk.org/jdk/pull/14497#discussion_r1273426634
PR Review Comment: https://git.openjdk.org/jdk/pull/14497#discussion_r1273426830
PR Review Comment: https://git.openjdk.org/jdk/pull/14497#discussion_r1273426730