RFR: JDK-8313164: src/java.desktop/windows/native/libawt/windows/awt_Robot.cpp GetRGBPixels adjust releasing of resources [v2]

Matthias Baesken mbaesken at openjdk.org
Wed Jul 26 11:59:06 UTC 2023


> In src/java.desktop/windows/native/libawt/windows/awt_Robot.cpp GetRGBPixels we release some resources at the end of the function by calling DeleteObject/DeleteDC. This is recommended by the MS API docs.
> However this should be done as well in some early leaving with throw that can occur in this function.

Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:

  adjust checks and calculation of numPixels

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/15038/files
  - new: https://git.openjdk.org/jdk/pull/15038/files/9403dc41..95283db0

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=15038&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15038&range=00-01

  Stats: 9 lines in 1 file changed: 8 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/15038.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15038/head:pull/15038

PR: https://git.openjdk.org/jdk/pull/15038



More information about the client-libs-dev mailing list