Integrated: JDK-8313164: src/java.desktop/windows/native/libawt/windows/awt_Robot.cpp GetRGBPixels adjust releasing of resources

Matthias Baesken mbaesken at openjdk.org
Thu Jul 27 07:09:48 UTC 2023


On Wed, 26 Jul 2023 10:43:20 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> In src/java.desktop/windows/native/libawt/windows/awt_Robot.cpp GetRGBPixels we release some resources at the end of the function by calling DeleteObject/DeleteDC. This is recommended by the MS API docs.
> However this should be done as well in some early leaving with throw that can occur in this function.

This pull request has now been integrated.

Changeset: b7545a69
Author:    Matthias Baesken <mbaesken at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/b7545a69a27f255cbf26071be5b88f6e3e6b3cd6
Stats:     20 lines in 1 file changed: 17 ins; 0 del; 3 mod

8313164: src/java.desktop/windows/native/libawt/windows/awt_Robot.cpp GetRGBPixels adjust releasing of resources

Reviewed-by: stuefe

-------------

PR: https://git.openjdk.org/jdk/pull/15038



More information about the client-libs-dev mailing list