RFR: 8311031: JTable header border vertical lines are not aligned with data grid lines [v9]

Alexey Ivanov aivanov at openjdk.org
Mon Jul 31 20:43:59 UTC 2023


On Thu, 27 Jul 2023 04:58:33 GMT, Tejesh R <tr at openjdk.org> wrote:

>> The header border uses `g.drawLine` whereas the JTable data grid lines uses `SwingUtilities2.drawVLine` and `SwingUtilities2.drawHLine` to draw horizontal and vertical lines. The SwingUtilities2 uses `Graphics.fillRect` which contributes to the difference between the position of these two lines which happens/visible at higher ui scaling (difference in alignment between vertical lines of these two). The fix propose to use the same methods for metal L&F of JTable header border paint. 
>> CI testing shows green.
>> 
>> ![image](https://github.com/openjdk/jdk/assets/94159358/f6d1d822-55ba-4ad3-9914-d3f68b67a6c5)
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review fix

test/jdk/javax/swing/JTableHeader/TableHeaderBorderPositionTest.java line 127:

> 125:             e.printStackTrace();
> 126:         }
> 127:     }

In fact, it looks better with `saveImage` method.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14766#discussion_r1279849664



More information about the client-libs-dev mailing list