RFR: 7083187: Class CSS.CssValue is missing implementations of equals() and hashCode() [v12]

Prasanta Sadhukhan psadhukhan at openjdk.org
Thu Jun 1 03:03:18 UTC 2023


On Wed, 31 May 2023 12:55:45 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Two CSS AttributeSet-s can be compared using the AttributeSet.isEqual() method which can fail due to missing implementation of equals method in CSS subclasses.
>> In this issue, even when two CSS AttributeSet has same 42 font size string value, Object equality fails.
>> Fixed by implementing the equality and hashCode method for CSS.FontSize class.
>> 
>> All jtreg/jck tests are ok
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use local objects for FontSize as per review comment

@prrace @aivanov-jdk Any further comments on this PR? I would like to get it in by RDP1 if it is possible and I guess contentious issues are sorted

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13405#issuecomment-1571254937



More information about the client-libs-dev mailing list