RFR: 7083187: Class CSS.CssValue is missing implementations of equals() and hashCode() [v14]

[Phil Race]

On Thu, 1 Jun 2023 08:26:45 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Two CSS AttributeSet-s can be compared using the AttributeSet.isEqual() method which can fail due to missing implementation of equals method in CSS subclasses.
>> In this issue, even when two CSS AttributeSet has same 42 font size string value, Object equality fails.
>> Fixed by implementing the equality and hashCode method for CSS.FontSize class.
>> 
>> All jtreg/jck tests are ok
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use relative variable in equals/hashcode

src/java.desktop/share/classes/javax/swing/text/html/CSS.java line 2684:

> 2682:             return val instanceof CSS.LengthValue lu
> 2683:                    && Objects.equals(svalue, lu.svalue);
> 2684:         }

Why is this case still using the string and not 'span' ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13405#discussion_r1213533619