RFR: 8297923: java.awt.ScrollPane broken after multiple scroll up/down

Sergey Bylokhov serb at openjdk.org
Wed Jun 7 03:33:59 UTC 2023


On Tue, 6 Jun 2023 18:22:01 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> src/java.desktop/windows/native/libawt/windows/awt_ScrollPane.cpp line 704:
>> 
>>> 702:     gos->orient = orient;
>>> 703: 
>>> 704:     return static_cast<jint>(reinterpret_cast<INT_PTR>(AwtToolkit::GetInstance().InvokeFunction(
>> 
>> So this needs to block until the toolkit thread can process this and return, but since its
>> directly called from Java (ie we are in a JNI method) I think this is likely fine.
>
> That's right.
> 
> In addition to that, `WScrollPanePeer.getScrollOffset` is unused, so it's never called.

If it is unused can we delete it?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14338#discussion_r1220780190



More information about the client-libs-dev mailing list