RFR: 7083187: Class CSS.CssValue is missing implementations of equals() and hashCode() [v15]

Alexey Ivanov aivanov at openjdk.org
Wed Jun 7 13:59:09 UTC 2023


On Wed, 7 Jun 2023 12:45:12 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> `BorderWidthValue` (it could be handled automatically by its superclass, `LengthValue`)

Yep, it's handled correctly `"border-width: medium"` passes the test.

> This comparison could fail for the case where there's a space before the `%` in the string.

`FontSize` does handle `{"font-size: 100%", "font-size: 100 %"}` pair, but `LengthValue` doesn't.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13405#issuecomment-1580879664
PR Review Comment: https://git.openjdk.org/jdk/pull/13405#discussion_r1221645885



More information about the client-libs-dev mailing list