RFR: 8297923: java.awt.ScrollPane broken after multiple scroll up/down
Alexey Ivanov
aivanov at openjdk.org
Wed Jun 7 20:54:50 UTC 2023
On Wed, 7 Jun 2023 20:32:40 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:
> > > Probably we should update the Java_sun_awt_windows_WScrollbarPeer_setValues as well? it calls the SetScrollInfo
> >
> >
> > You're right. It needs to be updated too. However, I'd rather do it separately.
>
> That is up2you, but it looks strange when the patch updates the code which is never executed and skips the code which is executed and has the bug
It has taken a very long time till the root cause for this bug was identified. I admit I was too focused on the code for `ScrollPane` only and I overlooked the fact that `::SetScrollInfo` is also used in `ScrollBar`.
As such, the updated code is limited to the native implementation of `ScrollPane`. Let's leave it this way.
Thank you for finding a similar problem in `ScrollBar`, it needs fixing too.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/14338#issuecomment-1581491086
More information about the client-libs-dev
mailing list