RFR: 7083187: Class CSS.CssValue is missing implementations of equals() and hashCode() [v17]
Prasanta Sadhukhan
psadhukhan at openjdk.org
Thu Jun 8 10:28:17 UTC 2023
> Two CSS AttributeSet-s can be compared using the AttributeSet.isEqual() method which can fail due to missing implementation of equals method in CSS subclasses.
> In this issue, even when two CSS AttributeSet has same 42 font size string value, Object equality fails.
> Fixed by implementing the equality and hashCode method for CSS.FontSize class.
>
> All jtreg/jck tests are ok
Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
Fix percentage equality as per span parsed value
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/13405/files
- new: https://git.openjdk.org/jdk/pull/13405/files/9d03fa86..94249f77
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=13405&range=16
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=13405&range=15-16
Stats: 20 lines in 2 files changed: 0 ins; 10 del; 10 mod
Patch: https://git.openjdk.org/jdk/pull/13405.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/13405/head:pull/13405
PR: https://git.openjdk.org/jdk/pull/13405
More information about the client-libs-dev
mailing list