RFR: 7083187: Class CSS.CssValue is missing implementations of equals() and hashCode() [v15]
Prasanta Sadhukhan
psadhukhan at openjdk.org
Thu Jun 8 10:28:18 UTC 2023
On Thu, 8 Jun 2023 07:19:26 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> I am not sure on 100%, 200% ie >= 100% should be considered equal or not..I could not find in spec...also the URL I gave has 200% as valid value...so as of now I have considered what is normal and made `equals` return false for different percentages irrespective of < or > 100%..
>
> I also think that capping at 100% is wrong but it's another bug.
>
> Currently, both 100% and 200% result in attribute sets which behave as if both were 100%, therefore they should be equal. I strongly believe we should compare the parsed values not the input string.
OK. Fair enough..guess CSS implementation and equality should match...Modified...
Upper capping and equality can be looked at later if needed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13405#discussion_r1222823156
More information about the client-libs-dev
mailing list