RFR: 7083187: Class CSS.CssValue is missing implementations of equals() and hashCode() [v18]

Alexey Ivanov aivanov at openjdk.org
Thu Jun 8 12:01:02 UTC 2023


On Thu, 8 Jun 2023 11:58:18 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Two CSS AttributeSet-s can be compared using the AttributeSet.isEqual() method which can fail due to missing implementation of equals method in CSS subclasses.
>> In this issue, even when two CSS AttributeSet has same 42 font size string value, Object equality fails.
>> Fixed by implementing the equality and hashCode method for CSS.FontSize class.
>> 
>> All jtreg/jck tests are ok
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix per review comment

Perfect! Looks to me now.

-------------

Marked as reviewed by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13405#pullrequestreview-1469749282



More information about the client-libs-dev mailing list