RFR: JDK-8309703: AIX build fails after JDK-8280982 [v2]

[Martin Doerr]

On Fri, 9 Jun 2023 10:42:59 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> After
>> [JDK-8280982](https://bugs.openjdk.org/browse/JDK-8280982): [Wayland] [XWayland] java.awt.Robot taking screenshots
>> the AIX build fails.
>> We get
>> 
>> * For target support_native_java.desktop_libawt_xawt_screencast_pipewire.o:
>> In file included from /aixbuild/jdk-dev/src/java.desktop/unix/native/libawt_xawt/awt/screencast_pipewire.c:33:
>> In file included from /aixbuild/jdk-dev/src/java.desktop/unix/native/libawt_xawt/awt/screencast_pipewire.h:40:
>> In file included from /aixbuild/jdk-dev/src/java.desktop/unix/native/libpipewire/include/spa/debug/types.h:17:
>> In file included from /aixbuild/jdk-dev/src/java.desktop/unix/native/libpipewire/include/spa/utils/type-info.h:33:
>> In file included from /aixbuild/jdk-dev/src/java.desktop/unix/native/libpipewire/include/spa/param/type-info.h:8:
>> In file included from /aixbuild/jdk-dev/src/java.desktop/unix/native/libpipewire/include/spa/param/param-types.h:50:
>> In file included from /aixbuild/jdk-dev/src/java.desktop/unix/native/libpipewire/include/spa/param/audio/type-info.h:8:
>> In file included from /aixbuild/jdk-dev/src/java.desktop/unix/native/libpipewire/include/spa/param/audio/raw-types.h:18:
>> /aixbuild/jdk-dev/src/java.desktop/unix/native/libpipewire/include/spa/param/audio/raw.h:15:10: fatal error: 'endian.h' file not found
>> 
>> I cannot find endian.h on my AIX machine.
>> Instead there is <sys/machine.h> which provides some info on byte order etc. instead .
>> 
>> Additionally we have a "warning as error"  in src/java.desktop/unix/native/libawt_xawt/awt/screencast_pipewire.c ; xlc17 clang 15 is very picky about the vfprintf used there. I disabled the warning.
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   use BIG_ENDIAN in define

LGTM. Thanks for fixing it. We should consider fixing it upstream, too (https://github.com/PipeWire/pipewire).

-------------

Marked as reviewed by mdoerr (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14390#pullrequestreview-1471712833