RFR: 4516654: Metalworks Demo: Window title not displayed fully in Low Vision Theme [v2]

[Alexey Ivanov]

On Fri, 9 Jun 2023 05:33:19 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> In Metalworks demo in Low Vision theme, window title is not diplayed fully in this theme. The first letter of the title, that is letter "M", is cut vertically
>> 
>> ![image](https://github.com/openjdk/jdk/assets/43534309/b122787c-8144-4771-a74a-71b60e1a63f9)
>> 
>> It is because the iconsize is hardcoded to be 30 and windows titlePane title is rendered at same place irrespective of theme (only font size is made bigger from normal pt 12 to 24 for Low Vision theme) so icon width overlaps the title.
>> Icon width is made to be 24 in demo in sync with window title font size which made it work ok
>> 
>> ![image](https://github.com/openjdk/jdk/assets/43534309/fa61f2cb-8339-4e92-8612-b1d8d32e8b7f)
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix

Marked as reviewed by aivanov (Reviewer).

src/demo/share/jfc/Metalworks/BigContrastMetalTheme.java line 128:

> 126:         table.put("PasswordField.border", textBorder);
> 127:         table.put("TextArea.border", textBorder);
> 128:         table.put("TextPane.font", controlFont);

Does this change also contributes to the fix?

-------------

PR Review: https://git.openjdk.org/jdk/pull/14346#pullrequestreview-1471689886
PR Review Comment: https://git.openjdk.org/jdk/pull/14346#discussion_r1224138751